Añade pruebas para la búsqueda de bookmarks en src/search.js#32
Open
ChuyB wants to merge 2 commits intoUSB-CI3715:f24from
Open
Añade pruebas para la búsqueda de bookmarks en src/search.js#32ChuyB wants to merge 2 commits intoUSB-CI3715:f24from
ChuyB wants to merge 2 commits intoUSB-CI3715:f24from
Conversation
Pull Request Test Coverage Report for Build 11317411374Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Este PR añade tres pruebas que revisan la búsqueda de posts en bookmarks de usuarios para cubrir código que no tenía pruebas asociadas.
¿Cómo se añadieron las pruebas?
Las pruebas le añaden a un usuario un post a sus bookmarks. Luego, se realiza una búsqueda de los bookmarks del usuario y se revisa que se hayan encontrado correctamente. Por otro lado, también se revisa que, si la búsqueda no debe retornar nada si el usuario no tiene bookmarks o si la cadena de caracteres a buscar no coincide con el bookmark asociado al usuario, efectivamente no retorne algún post.
Screenshots
Antes de los cambios:
Al añadir los cambios:
Cierra #30.